Skip to content

F test linkify

Timm Fitschen requested to merge f-test-linkify into dev

Summary

Completes the implementation of ext_cosmetics.linkify (#239 (closed)) and adds tests (#210 (closed)).

Focus

The original implementation was just in a proof-of-concept state. The completion of the implementation takes care of multiple links and links surrounded by other text as well.

Test Environment

For manual testing:

  1. Enable "linkify" by putting BUILD_MODULE_EXT_COSMETICS_LINKIFY=ENABLED into one of your build files (./build.properties.d/here.properties)
  2. call make/start container
  3. insert test data via ./mist/ext_cosmetics_test_data.py.
  4. View the result in the webui

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading