Skip to content

Fix safari edit mode and entity preview

Timm Fitschen requested to merge f-fix-safari-edit-mode into dev

Summary

Fixes #156 (closed) and #160 (closed)

The general strategy here was fixing as much unit tests as possible for Safari and then hope that the edit mode (and entity preview) is fixed automatically.

Therefore, a lot of small changes have happened. However, the most important take-away is that Safari is way more strict (or dumb?) when it comes to XML, XSLT and HTML. E.g. it does not allow <tr> elements without direct <table> parents, it is very pedantic with XML namespaces (conversion from 'XMLDocuments to HTMLDocuments and vice-versa can break things). Apparently, DocumentFragment(a lightweight alternative toDocument`s) could not be transformed by our XSLT functions - I still don't understand why.

Note: I also removed the (unnecessary) ext_revisions module because the tests kept failing in safari and I didn't want to deal with them.

Test Environment

Please test insert/edit/delete and the entity preview with a Safari browser.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports