Draft: F fix get parents

Summary

This is a fix for #157 .

The other functions in caosdb.js need to be checked for similar problems.

This was implemented by @salexan a while ago.

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/core/js/tour.js

@@ -364,7 +364,7 @@ var tour = new function () {
 
             // initialize next/prev buttons
             var nb = popover.find("button[data-role=next]")
-            if (this.get_next()){
+            if (this.get_next()) {
                 nb.on("click", (e) => {
                     const pn = this.get_next()
                     pn.activate(true);
@@ -376,10 +376,10 @@ var tour = new function () {
                     }
                 });
             } else {
-                nb.prop("disabled", true);
+                nb.toggleClass("invisible", true);
             }
             var pb = popover.find("button[data-role=prev]")
-            if (this.get_previous()){
+            if (this.get_previous()) {
                 pb.on("click", (e) => {
                     const pp = this.get_previous()
                     pp.activate(true);
@@ -391,7 +391,7 @@ var tour = new function () {
                     }
                 });
             } else {
-                pb.prop("disabled", true);
+                pb.toggleClass("invisible", true);
             }
         }
 
@@ -565,10 +565,10 @@ var tour = new function () {
             if (button.is(".caosdb-f-tour-open-page")) {
                 return; // already open
             }
-            if (! $(this.config["target"])[0]) {
+            if (!$(this.config["target"])[0]) {
                 return; // element to attach to not available; can't open
             }
-            if (this.get_next()){
+            if (this.get_next()) {
                 logger.debug(`Set next page in session store to `, this.get_next().config.id);
                 sessionStorage["tour-page-open-next"] = this.get_next().config.id
             }
@@ -639,7 +639,7 @@ var tour = new function () {
                 this.parent_set._activate()
 
                 if (this.initialized && sessionStorage["tour-page-open-next"] == this.config.id) {
-                    if ($(this.config["target"])[0]){
+                    if ($(this.config["target"])[0]) {
                         this._open();
                     } else {
                         tour._post_init_cb.push(() => {
@@ -1277,7 +1277,7 @@ var tour = new function () {
             if (this.config.deactivate_other) {
                 logger.debug("Close pagesets other than '" + trigger.id + "'.");
                 for (const element of this.elements) {
-                    if ( element.isPageSet && element !== trigger) {
+                    if (element.isPageSet && element !== trigger) {
                         element.deactivate();
                     }
                 }
@@ -1330,7 +1330,7 @@ var tour = new function () {
             });
         }
 
-        if (typeof sessionStorage["tour-page-open-next"]=== "undefined") {
+        if (typeof sessionStorage["tour-page-open-next"] === "undefined") {
             sessionStorage["tour-page-open-next"] = instance._tour_pages[0];
         }
         instance.init_activation(config.persistent_state);
@@ -1377,4 +1377,4 @@ var tour = new function () {
 };
 
 
-$(document).ready(tour.init);
+$(document).ready(tour.init);
\ No newline at end of file