Skip to content

remove xs

Henrik tom Wörden requested to merge f-xs into dev

Summary

Since the bootstrap 5 modals do no longer need an extra character that is displayed as the closing "x". The "close-char" parameter is no longer needed.

Focus

This MR removes two locations, where the close-char variable is set and one where the variable is defined. Even before the MR this variable seems not to be used any where.

Test Environment

Unit test + open a modal

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Merge request reports