Skip to content
Snippets Groups Projects

fix paging

Merged fix paging
f-fix-paging2 into f-boot-tour
1 unresolved thread
Merged Timm Fitschen requested to merge f-fix-paging2 into f-boot-tour
1 unresolved thread

Summary

The paging did not initialize because the init() function was never called. see #214 (closed)

Test Environment

Start LA with this branch in the default profile.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Pipeline #8149 passed with warnings

Stage: linting
Stage: test
Stage: deploy
Pipeline: LinkAhead

#8150

    Pipeline passed with warnings for 6f8fb0bd on f-fix-paging2

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 3 years ago (Jun 3, 2021 10:32am UTC)

    Merge details

    • Changes merged into f-boot-tour with 0754db9b.
    • Deleted the source branch.

    Pipeline #8154 passed with warnings

    Stage: linting
    Stage: test
    Stage: deploy
    Pipeline: LinkAhead

    #8155

      Pipeline passed with warnings for 0754db9b on f-boot-tour

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      src/core/js/webcaosdb.js
      1867 1867 };
      1868 1868 }($, connection, createWaitingNotification, createErrorNotification);
      1869 1869
      1870 /**
    • Timm Fitschen
    • Timm Fitschen added 1 commit

      added 1 commit

      • dcfbc173 - WIP: fix paging with old auth token

      Compare with previous version

    • Timm Fitschen added 1 commit

      added 1 commit

      Compare with previous version

    • Henrik tom Wörden marked the checklist item I understand the intent of this MR as completed

      marked the checklist item I understand the intent of this MR as completed

    • Henrik tom Wörden marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md as completed

      marked the checklist item Up-to-date CHANGELOG.md as completed

    • Henrik tom Wörden marked the checklist item The test environment setup works and the intended behavior is as completed

      marked the checklist item The test environment setup works and the intended behavior is as completed

    • Henrik tom Wörden marked the checklist item In-code documentation and comments are up-to-date. as completed

      marked the checklist item In-code documentation and comments are up-to-date. as completed

    • Henrik tom Wörden marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

      marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    • Henrik tom Wörden marked this merge request as ready

      marked this merge request as ready

    • Henrik tom Wörden mentioned in commit 0754db9b

      mentioned in commit 0754db9b

    • Henrik tom Wörden merged

      merged

      • Please register or sign in to reply