FIX: Re-enable file-upload button
All threads resolved!
All threads resolved!
Summary
The file-upload button was disabled by the migration to Bootstrap 5 (#200 (closed)).
Focus
One-liner in src/ext/fileupload.js
and some styling.
Test Environment
Use this branch and, e.g., the default profile of deploy and try to upload a file as a property using the edit mode.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Activity
- Resolved by Timm Fitschen
- Resolved by Timm Fitschen
- Resolved by Timm Fitschen
requested review from @timm
added 3 commits
-
2a672d7d...b6181e19 - 2 commits from branch
f-boot-tour
- 952b3ae8 - Merge branch 'f-boot-tour' into f-upload-button
-
2a672d7d...b6181e19 - 2 commits from branch
mentioned in commit f315c481
Please register or sign in to reply