Skip to content

FIX: Repair entity sizing with long property values

Florian Spreckelsen requested to merge f-bs5-awi into f-boot-tour

Summary

Fixes a problem whereby too long property values (e.g., long list properties) would cause line breaks and would move the edit mode box outside the view port. Also fixes changing the map view.

Focus

Some css changes, also the entering the edit mode now toggles an addtional class for .caosdb-f-main-entities.

Test Environment

Create a record with a reference property with a long list of references as a value -- the list has to be long enough for the previews to overflow the property value column. Verify that this doesn't cause a line break in the property row. Also verify that even on small an iPad viewport, the edit mode box stays in view. Also check that changing the map view, e.g., from mercator to polar, doesn't lead to a grey box appearing above the actual map.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports