Skip to content

ENH: Show min-width warning in tour and edit mode

Florian Spreckelsen requested to merge f-min-width-warning into f-boot-tour

Summary

Introduce a warning that is shown in tour and edit mode when viewed on small screens (#194 (closed) ).

Focus

The warning elements and the toggling have been added to tour.js and edit_mode.js.

Test Environment

Simply open and close the tour while reducing the window size and check that the warning appears if and only if the tour is open on small screens. Log in and verify the same for the edit mode.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports