Skip to content

ENH: attach popovers to elements on the page directly

Henrik tom Wörden requested to merge f-direct-popover into f-boot-tour

Summary

Before, popovers often overlapped with content of interest because they were attached to the buttons. Now, buttons are not shown by default and popovers are attached to page elements directly.

Focus

Note, that this does no longer allow to use getInstance of bootstrap, since multiple popovers may be attached to the same object. The page object now contains a reference to the popovers.

Test Environment

Set show_button=true for at least one page and check the behaviour.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Merge request reports