Skip to content

ENH: allow tour page to be shown on reload

Henrik tom Wörden requested to merge f-reload into f-boot-tour

Summary

Before, when a user action would lead to a page reload with location change the next button was not visible and no popup would open. Now this is done correctly.

Focus

Page.activate(deactivate_other) has now an argument. This allows to activate the next tour page on open of the current without closing all. Additionally, there is a minor change with regard to the sessionStorage["tour-page-open-next"]: by default the value is the next page.

Test Environment

go to the second page of the search chapter and submit the right query.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports