Skip to content

FIX: Set horizontal scroll of property names to auto

Florian Spreckelsen requested to merge f-fix-dead-scroll-bar into dev

Summary

Fix for #355 (closed) introduced by 385e6894. Removes the dead scroll bars that are shown in chromium-based browsers and some(?) Firefox versions.

Focus

Just set overflow-x to auto instead of scroll, thus only expressing scroll behavior were needed.

Test Environment

Create a property with a short name (e.g., SomeProp) and one with a long name without spaces (e.g., SomePropWithAVeryLooooooooooooooooooooooooooooooooooooooooooooooooooongName), and create a RecordType with both properties attached:

SomeType:
  suggested_properties:
    SomeProp:
      datatype: TEXT
    SomePropWithAVeryLooooooooooooooooooooooooooooooooooooooooooooooooooongName:
      datatype: TEXT

Repeat with chromium, firefox, and whatever browser you have:

  1. Visit this RecordType in the web interface and verify that the property with a short name doesn't have a scroll bar while the one with a long name has.
  2. Also do some SELECT queries until the resulting table becomes wider than the window. Verify that a x-scroll bar only appears when the table becomes too wide and is hidden otherwise.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports