F fix max dropdown options

Summary

Fix for #345 (closed). Send the correct query string in case of BUILD_MAX_EDIT_MODE_DROPDOWN_OPTIONS=-1.

Focus

The original problem was that unlimited dropdown options would result in a P0L-1 query being sent, so this is now caught specifically.

Test Environment

Start LinkAhead with BUILD_MAX_EDIT_MODE_DROPDOWN_OPTIONS=-1 (i.e., default) and enter several hundred records, e.g., by

import linkahead as db
rt = db.RecordType(name="Test").insert()
db.Container().extend([db.Record(name=f"Rec{ii+1}").add_parent(rt) for ii in range(500)]).insert()

then, add Test as a reference prop to any entity and verify that all 500 records can be selected.

As a comparison, repeat for BUILD_MAX_EDIT_MODE_DROPDOWN_OPTIONS=10 and verify that it stops correctly after the first 10 entries and offers the possibility to enter an id manually.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/core/js/edit_mode.js

@@ -1033,14 +1033,16 @@ var edit_mode = new function () {
                         $(manualInsertButton).click(function () {
                             // toggle input
                             // forward:
-                            if ($(result).find('input.caosdb-f-manual-id-insert').is(':hidden')){
+                            if ($(result).find('input.caosdb-f-manual-id-insert').is(':hidden')) {
                                 // show ID input; hide dropdown
                                 $(result).find('.dropdown').hide();
                                 $(result).find('input.caosdb-f-manual-id-insert').show();
                                 $('.caosdb-f-entity-save-button').hide()
                             } else {
                                 // backward:
-                                $(result).find('input.caosdb-f-manual-id-insert')[0].dispatchEvent(new KeyboardEvent('keyup', {'key':'Enter'}));
+                                $(result).find('input.caosdb-f-manual-id-insert')[0].dispatchEvent(new KeyboardEvent('keyup', {
+                                    'key': 'Enter'
+                                }));
                             }
                         });
                         // Add input for manual ID insertion
@@ -1053,8 +1055,8 @@ var edit_mode = new function () {
                                 // was entered to the candidates and select that item
                                 $(result).find('input.caosdb-f-manual-id-insert').hide();
                                 var sel_id = $(result).find('input.caosdb-f-manual-id-insert')[0].value
-                                if (sel_id!=""){
-                                    if ($(result).find(`option[value="${sel_id}"]`).length==0){
+                                if (sel_id != "") {
+                                    if ($(result).find(`option[value="${sel_id}"]`).length == 0) {
                                         select.append(`<option value="${sel_id}">ID: ${sel_id}</option>`);
                                         // workaround for selectpicker bug (options are
                                         // doubled otherwise)
@@ -1891,14 +1893,16 @@ var edit_mode = new function () {
      *     which can be referenced by the property.
      */
     this.retrieve_datatype_list = async function (datatype) {
-        var find_entity = ["FILE", "REFERENCE"].includes(datatype) ? "" : `"${datatype}"`;
+        const find_entity = ["FILE", "REFERENCE"].includes(datatype) ? "" : `"${datatype}"`;
         const max_options = parseInt("${BUILD_MAX_EDIT_MODE_DROPDOWN_OPTIONS}"); //for each query; there might be more candidates in total
-        if (max_options != -1){
+
+        const query_suffix = max_options != -1 ? `&P=0L${max_options}` : "";
+        if (max_options != -1) {
             var n_entities = datatype !== "FILE" ? await edit_mode.query(`COUNT Record ${find_entity}`, true) : 0;
             var n_files = await edit_mode.query(`COUNT File ${find_entity}`, true);
         }
-        var entities = datatype !== "FILE" ? edit_mode.query(`FIND Record ${find_entity}&P=0L${max_options}`, true) : [];
-        var files = edit_mode.query(`FIND File ${find_entity}&P=0L${max_options}`, true);
+        const entities = datatype !== "FILE" ? edit_mode.query(`FIND Record ${find_entity}${query_suffix}`, true) : [];
+        const files = edit_mode.query(`FIND File ${find_entity}${query_suffix}`, true);
 
         await Promise.all([entities, files])
 
@@ -1907,7 +1911,7 @@ var edit_mode = new function () {
             .concat(edit_mode
                 ._create_reference_options(await files));
 
-        if (max_options !=- 1 && (n_entities > max_options || n_files > max_options)) {
+        if (max_options != -1 && (n_entities > max_options || n_files > max_options)) {
             // add notification that not all entities are shown
             options = [$(`<option disabled=true value="NA"/>`).text(
                 `More than ${max_options} possible options; showing only a subset. You may need to enter the id manually.`