No changes in the react code necessary, the shortcut container is simply squeezed between query form and tabs (I liked it better here than below the tabs).
Is the placement ok?
Is the styling ok enough for now?
Is the behavior when scrolling ok? I.e., vanishing shortcuts when query panel minimizes.
Test Environment
Use a profile that has query shortcuts (e.g., the demo profile). Start with BUILD_MODULE_LEGACY_QUERY_FORM=DISABLED and WebUI in this branch. Test the new query panel together with shortcuts. Then, disable new query panel (i.e., BUILD_MODULE_LEGACY_QUERY_FORM=DISABLED) and verify that everything works as before.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab
comments for the reviewer. They should guide the reviewer through the changes, explain your changes
and also point out open questions. For further good practices have a look at our review
guidelines
All automated tests pass
Reference related issues
Up-to-date CHANGELOG.md (or not necessary)
Up-to-date JSON schema (or not necessary)
Appropriate user and developer documentation (or not necessary)
How do I use the software? Assume "stupid" users.
How do I develop or debug the software? Assume novice developers.
Annotations in code (Gitlab comments)
Intent of new code
Problems with old code
Why this implementation?
Check List for the Reviewer
I understand the intent of this MR
All automated tests pass
Up-to-date CHANGELOG.md (or not necessary)
Appropriate user and developer documentation (or not necessary)
The test environment setup works and the intended behavior is reproducible in the test
environment
In-code documentation and comments are up-to-date.
Check: Are there specifications? Are they satisfied?
Florian Spreckelsen authored