FIX: use paging during options generation in edit mode

Summary

Implementation for https://gitlab.com/linkahead/linkahead-webui/-/issues/216

Focus

• Queries that retrieve entities that are candiates for drop down use paging.
• A Count Query identifies whether more enties would be available. If so, an option to enter an ID manually is included (a button ) and the dropdown shows a warning that it does not include all entities.

Test Environment

• manually test the behavior

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

assigned to @henrik

added 1 commit

• 2512e021 - tst

Compare with previous version

added 1 commit

• 1ea1a418 - FIX: refactor and fix test

Compare with previous version

mentioned in issue #318 (closed)

marked the checklist item All automated tests pass as completed

marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

marked the checklist item Reference related issues as completed

marked the checklist item Up-to-date JSON schema (or not necessary) as completed

marked the checklist item Annotations in code (Gitlab comments) as completed

marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

added 1 commit

• affb4a1f - MAINT: minor cleanup

Compare with previous version

requested review from @florian

added 6 commits

• affb4a1f...7a372ef8 - 5 commits from branch dev
• 78ff86b4 - Merge branch 'dev' into f-edit-mode-paging

Compare with previous version

marked the checklist item I understand the intent of this MR as completed

marked the checklist item All automated tests pass as completed

resolved all threads

added 2 commits

• 7ddb79f5 - MAINT: js-beautified and remove TODO
• 21d6e7cf - FIX: Scoping of result variable

Compare with previous version

This is still broken unfortunately, see with max_count = 2 for testing and 4 TestType records.

Also, if no value had been selected prior to editing, an additional ID: option with empty value (<option value="">ID: </option>) at the bottom of the list.

Last, we should add a hint to the edit mode tutorial describing the new behavior. E.g., explain how the contents of the dropdown change, and how a SELECT ID FROM ... query can be used to find the values that you want to enter manually.

added 1 commit

• 78e126d7 - FIX: deal with async call and no preexisting reference

Compare with previous version

added 1 commit

• 56cbe6c8 - DOC: add hint about the manual ID insertion

Compare with previous version

added 1 commit

• 67b763a9 - FIX: deal with empty options list

Compare with previous version

added 7 commits

• 67b763a9...19b5285c - 6 commits from branch dev
• b3a15f5a - Merge branch 'dev' into f-edit-mode-paging

Compare with previous version

added 1 commit

• 43cc5d97 - ENH: Better notification for overfull dropdown menu

Compare with previous version

The above comments have been addressed, however, there is more:

• Entering an id manually doesn't work for me. I can switch to id entering by clicking on the pencil but after saving, the property has an empty value.
• Same for elements of lists of references: manually entered ids appear as empty values in list
• After clicking on the pencil to enter the id manually, there is no way of returning to the dropdown menu.
• Should we make this configurable? Introduce a BUILD_MAX_EDIT_MODE_DROPDOWN_OPTIONS variable that can be set by the user? Setting it to 0 or -1 could be equivalent to infty.

Ah, after rebuild, pressing enter works in scalar properties! In Lists however, it leads to this:

added 2 commits

• 86fd4d25 - DOC: enhance hint
• 08d2d6ae - FIX: fix scoping to allow lists

Compare with previous version

added 1 commit

• b1df439b - ENH: introduce a build var for max_options

Compare with previous version

added 1 commit

• 4366858f - DOC: add config doc

Compare with previous version

added 1 commit

• 91401055 - TST: enable new limit for tests

Compare with previous version

added 1 commit

• 62148a94 - FIX: declare variable

Compare with previous version

resolved all threads

marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

marked the checklist item In-code documentation and comments are up-to-date. as completed

marked the checklist item Check: Are there specifications? Are they satisfied? as completed

added 1 commit

• 757ba23f - FIX: Use correct file type for documentation

Compare with previous version

approved this merge request

enabled an automatic merge when the pipeline for 757ba23f succeeds

mentioned in commit b2e0b797

merged