Skip to content
Snippets Groups Projects

FIX: breaking datetime in edit mode

Merged Henrik tom Wörden requested to merge f-fix-datetime into dev
All threads resolved!

Summary

Fix for https://gitlab.com/linkahead/linkahead-webui/-/issues/239

Focus

  1. Introduce a trim to deal with whitespaces
  2. add subseconds to tag attribute to preserve it.

This is far from perfect but substantially improves status quo: First of all we do no longer destroy timestamps simply by using the edit mode (and without even touching the timestamp). Subsecond resolution can still not be changed, but at least it is preserved!

Do we need to deal with time zones as well?

Test Environment

  • pipelines
  • manually test:
    1. click Edit and then Save on an entity with a timestamp with sub seconds. Check that it did not change
    2. do the same for list properties

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Pipeline #41916 passed

Pipeline passed for f6bd17b6 on f-fix-datetime

Approved by

Merged by Timm FitschenTimm Fitschen 1 year ago (Oct 10, 2023 7:54am UTC)

Merge details

  • Changes merged into dev with 19b5285c.
  • Deleted the source branch.

Pipeline #41984 passed

Pipeline passed for 19b5285c on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Henrik tom Wörden
  • Henrik tom Wörden changed the description

    changed the description

  • Henrik tom Wörden requested review from @timm

    requested review from @timm

  • added 6 commits

    Compare with previous version

  • Timm Fitschen
  • Timm Fitschen
  • added 1 commit

    • f6bd17b6 - TST: add unit test for two functions

    Compare with previous version

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Timm Fitschen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Timm Fitschen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Timm Fitschen resolved all threads

    resolved all threads

  • Timm Fitschen approved this merge request

    approved this merge request

  • Timm Fitschen mentioned in commit 19b5285c

    mentioned in commit 19b5285c

  • merged

  • Please register or sign in to reply
    Loading