Skip to content

FIX: breaking datetime in edit mode

Henrik tom Wörden requested to merge f-fix-datetime into dev

Summary

Fix for https://gitlab.com/linkahead/linkahead-webui/-/issues/239

Focus

  1. Introduce a trim to deal with whitespaces
  2. add subseconds to tag attribute to preserve it.

This is far from perfect but substantially improves status quo: First of all we do no longer destroy timestamps simply by using the edit mode (and without even touching the timestamp). Subsecond resolution can still not be changed, but at least it is preserved!

Do we need to deal with time zones as well?

Test Environment

  • pipelines
  • manually test:
    1. click Edit and then Save on an entity with a timestamp with sub seconds. Check that it did not change
    2. do the same for list properties

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports