ENH: Add auto_focus and pattern to form_elements/form_panel
Summary
Moves code from customer custom scripts to webui:
- Adds "pattern" option for text fields (module form_elements)
- Adds "auto_focus" parameter to form_panel module
Focus
Both features mentioned above are independent. They just happened to be developed simultaneously.
Test Environment
- See unit tests.
- Manual testing: Start the webui and execute this in the console:
var form_config = {
fields: [{
name: "test",
type:"text",
pattern: "[0-9A-F]+",
required: true,
},]
}
var cb = form_panel.create_show_form_callback("some_id", "Title", form_config);
navbar.add_tool("test", "toolbox", {callback: cb});
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen