F map bundle
Summary
- Fix for https://gitlab.com/caosdb/caosdb-webui/-/issues/226
- Add new react-based map which implements https://gitlab.com/caosdb/caosdb-webui/-/issues/205
- Introduce
BUILD_MODULE_LEGACY_MAP
which defaults toDISABLED
Related issues:
- https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/197
- #327 (closed)
- Map depends on caosdb-server#311 (closed)
Test Environment
- Please test with different values for
BUILD_MODULE_LEGACY_MAP
andBUILD_MODULE_LEGACY_QUERY_FORM
. - Please test the map with different
ext_map.json
. e.g. the default one will just disable the map.
Check List for the Author
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Timm Fitschen