F invisible error2
Summary
Nachbesserungen für #316 (closed)
Focus
- Errormessages im edit mode bei den properties waren nicht in der entity-messages liste. Daher war die Regel zu eng formuliert.
- Das message badge sollte eigentlich
float: right
haben. Aber seit Bootstrap 5 gibt es dafür eine neue Helper-Klasse,float-end
. - Das Padding der message badges in den properties wurde durch eine Regel in
tour.css
kaput gemacht, die aber garkeinen Anwendungsfall in unserer Tour hat. (grep "list-group-item" -r src/ - nix was mit tour zu tun hat.)
Test Environment
Nochmal mit Edit-Mode checken, bitte
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Timm Fitschen