Skip to content

Bug: invisible error

Timm Fitschen requested to merge f-invisible-error into dev

Summary

  1. Fix for https://gitlab.com/caosdb/caosdb-webui/-/issues/207 Related issue: #316 (closed)

  2. Unrelated: I notices that the "E" for "Entity" was not visible either and added a css rule for that as well.

Focus

There was a

Test Environment

Manual Testing:

  1. Request an entity which does not exist, e.g. https://localhost:10443/Entity/asdf
  2. Do the steps from https://gitlab.com/caosdb/caosdb-webui/-/issues/207
  3. Try and delete an entity which is required by other entities

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports