Skip to content
Snippets Groups Projects
Commit ef142703 authored by Henrik tom Wörden's avatar Henrik tom Wörden
Browse files

Merge branch 'f-review-async' into 'f-wysiwyg'

MAINT: replace promises by await

See merge request !57
parents 6b095dbc f6e7600f
No related branches found
No related tags found
3 merge requests!59REL: release 0.4.1,!57MAINT: replace promises by await,!56ENH: Add a WYSIWYG editor for text properties
Pipeline #16857 canceled
...@@ -39,15 +39,14 @@ ...@@ -39,15 +39,14 @@
*/ */
var ext_editmode_wysiwyg_text = function ($, logger, ClassicEditor, edit_mode, getPropertyElements, getPropertyDatatype, getPropertyName) { var ext_editmode_wysiwyg_text = function ($, logger, ClassicEditor, edit_mode, getPropertyElements, getPropertyDatatype, getPropertyName) {
var insertEditorInProperty = function (prop) { var insertEditorInProperty = async function (prop) {
if (!(getPropertyDatatype(prop) === 'TEXT')) { if (!(getPropertyDatatype(prop) === 'TEXT')) {
// Ignore anything that isn't a list property, even LIST<TEXT> // Ignore anything that isn't a list property, even LIST<TEXT>
return; return;
} }
let editor; try{
const editor = await ClassicEditor
ClassicEditor
.create(prop.querySelector('textarea'), { .create(prop.querySelector('textarea'), {
// use all plugins since we built the editor dependency to // use all plugins since we built the editor dependency to
// contain only those we need. // contain only those we need.
...@@ -60,21 +59,15 @@ var ext_editmode_wysiwyg_text = function ($, logger, ClassicEditor, edit_mode, g ...@@ -60,21 +59,15 @@ var ext_editmode_wysiwyg_text = function ($, logger, ClassicEditor, edit_mode, g
}, },
}, },
}) })
.then(newEditor => {
console.log('Initialized editor for ' + getPropertyName(prop)); console.log('Initialized editor for ' + getPropertyName(prop));
editor = newEditor;
}).then(
() => {
// Manually implement saving the data since edit mode is not // Manually implement saving the data since edit mode is not
// a form to be submitted. // a form to be submitted.
editor.model.document.on("change:data", (e) => { editor.model.document.on("change:data", (e) => {
editor.updateSourceElement(); editor.updateSourceElement();
}); });
} } catch(error) {
)
.catch(error => {
console.error(error.stack); console.error(error.stack);
}); }
} }
var replaceTextAreas = function (entity) { var replaceTextAreas = function (entity) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment