Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
C
caosdb-webui
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
caosdb
Software
caosdb-webui
Commits
855d1195
Commit
855d1195
authored
4 years ago
by
Alexander Schlemmer
Committed by
Florian Spreckelsen
4 years ago
Browse files
Options
Downloads
Patches
Plain Diff
FIX: bottom line now also works for entities larger than viewport
parent
4a24f4d9
No related branches found
No related tags found
1 merge request
!37
prepare release v0.3.1
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CHANGELOG.md
+2
-0
2 additions, 0 deletions
CHANGELOG.md
src/core/js/ext_bottom_line.js
+14
-1
14 additions, 1 deletion
src/core/js/ext_bottom_line.js
with
16 additions
and
1 deletion
CHANGELOG.md
+
2
−
0
View file @
855d1195
...
...
@@ -65,6 +65,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
-
summaries when opening preview
-
#125 special characters like "
\t
",
\"
n", "#" are replaced in table
download
-
#158 show preview if the entity is too large for the viewport if
bottom line is in view.
### Security (in case of vulnerabilities)
...
...
This diff is collapsed.
Click to expand it.
src/core/js/ext_bottom_line.js
+
14
−
1
View file @
855d1195
...
...
@@ -68,6 +68,19 @@
* @requires ext_table_preview (module from ext_table_preview.js)
*/
/**
* Helper function analogous to ext_references isOutOfViewport
*
* Check whether the bottom of an entity is within the viewport.
* Returns true when this is the case and false otherwise.
*
*/
function
is_bottom_in_viewport
(
entity
)
{
var
bounding
=
entity
.
getBoundingClientRect
();
return
bounding
.
bottom
>
0
&&
bounding
.
bottom
<
(
window
.
innerHeight
||
document
.
documentElement
.
clientHeight
);
}
var
ext_bottom_line
=
function
(
$
,
logger
,
is_in_view_port
,
load_config
,
getEntityPath
,
connection
,
UTIF
,
ext_table_preview
)
{
/**
...
...
@@ -568,7 +581,7 @@ var ext_bottom_line = function($, logger, is_in_view_port, load_config, getEntit
BottomLineWarning
:
BottomLineWarning
,
}
}(
$
,
log
.
getLogger
(
"
ext_bottom_line
"
),
resolve_references
.
is
_in_viewport
_vertically
,
load_config
,
getEntityPath
,
is_bottom
_in_viewport
,
load_config
,
getEntityPath
,
connection
,
UTIF
,
ext_table_preview
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment