Skip to content
Snippets Groups Projects
Commit 5e16d05a authored by Alexander Schlemmer's avatar Alexander Schlemmer
Browse files

FIX: bottom line now also works for entities larger than viewport

parent 00743d1e
No related branches found
No related tags found
1 merge request!90F citation cff
......@@ -68,6 +68,19 @@
* @requires ext_table_preview (module from ext_table_preview.js)
*/
/**
* Helper function analogous to ext_references isOutOfViewport
*
* Check whether the bottom of an entity is within the viewport.
* Returns true when this is the case and false otherwise.
*
*/
function is_bottom_in_viewport(entity) {
var bounding = entity.getBoundingClientRect();
return bounding.bottom > 0 && bounding.bottom < (window.innerHeight ||
document.documentElement.clientHeight);
}
var ext_bottom_line = function($, logger, is_in_view_port, load_config, getEntityPath, connection, UTIF, ext_table_preview) {
/**
......@@ -568,7 +581,7 @@ var ext_bottom_line = function($, logger, is_in_view_port, load_config, getEntit
BottomLineWarning: BottomLineWarning,
}
}($, log.getLogger("ext_bottom_line"),
resolve_references.is_in_viewport_vertically, load_config, getEntityPath,
is_bottom_in_viewport, load_config, getEntityPath,
connection, UTIF, ext_table_preview);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment