Skip to content
Snippets Groups Projects

ENH: add file-upload.js

Merged Timm Fitschen requested to merge f-file-upload into dev
All threads resolved!

Summary

  1. Add legacy adapter for the new FileUpload widget and integrate it into the legacy web interface (file system view).
  2. fix some minor issues with links to the file system

related: caosdb/customers/geomar/management#129

Focus

The new code is mainly concerned with integrating the file upload into the file system view. However, it is very easy to use the widget separately for a custom form (see geomar code for example).

Test Environment

Test with geomar setup

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Timm Fitschen marked the checklist item Up-to-date JSON schema (or not necessary) as completed

    marked the checklist item Up-to-date JSON schema (or not necessary) as completed

  • Timm Fitschen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen requested review from @florian

    requested review from @florian

  • mentioned in merge request caosdb-webui!117 (merged)

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • added 1 commit

    • adf145fd - MAINT: Use released core components

    Compare with previous version

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • added 1 commit

    • acfe25bb - FIX: Typo and remove resolved TODO comment

    Compare with previous version

  • Florian Spreckelsen approved this merge request

    approved this merge request

  • mentioned in commit c26f76bd

  • Please register or sign in to reply
    Loading