Skip to content

MAINT: Prevent Sass deprecation warnings

Florian Spreckelsenrequested to merge
f-no-googlefonts into dev

Summary

For #8. We use our own fork of files-ui-react which uses a dependency instead of geeting fonts from Google.

Focus

Only changed dependency.

Test Environment

npm install
npm run mock

and check that now calls to any google server are done anymore. Also verify that the Poppins fonts in the file upload area are still displayed correctly. For comparison, you can do the same in the dev branch and verify that the file upload area looks the same, but in dev, the fonts are fetched from Google.

You may also take a look at the upstream pull request to review the changes made upstream. Our published fork is now in https://gitlab.indiscale.com/caosdb/src/indiscale-files-ui-react or https://github.com/fspreck-indiscale/files-ui-react/tree/f-remove-googleapi for the lack of an official IndiScale GitHub group (see https://gitlab.indiscale.com/caosdb/internal/all/-/issues/2938).

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports