Skip to content

fixing server issue #196

Timm Fitschen requested to merge f-transaction-permissions into dev

Summary

  1. Fix for https://gitlab.com/caosdb/caosdb-server/-/issues/196.

  2. I removed the special permissions for the comment annotation. (These special permissions are only necessary for READ-ONLY users who are allowed to WRITE comments in the webinterface - which is a feature which is not used by anyone we know of. If anyone needs that, our normal permissions system is capable of doing that as well, even though that is a rather complex case)

  3. Also, as I was setting up everything from scratch on a new system, I corrected the docs for the setup and some default values.

Focus

The relevant changes are in src/main/java/org/caosdb/server/jobs/core/AccessControl.java

Test Environment

No manual testing required. caosdb-pyinttest!56 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports