Skip to content
Snippets Groups Projects

Use "trigger" keyword for pipeline.

Merged Use "trigger" keyword for pipeline.
f-trigger into dev
All threads resolved!
Merged Daniel Hornung requested to merge f-trigger into dev
All threads resolved!

Summary

Use "trigger" keyword for pipeline. See #238 (closed)

Focus

Are the variables set correctly?

Test Environment

Look at pipelines and see if they work.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Pipeline #24394 passed

Stage: info
Stage: test
Stage: deploy
Pipeline: LinkAhead

#24395

    Pipeline passed for 81f883a0 on f-trigger

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 2 years ago (Jun 22, 2022 8:36am UTC)

    Merge details

    • Changes merged into dev with bc7f40b4.
    • Deleted the source branch.

    Pipeline #24869 passed

    Stage: info
    Stage: setup
    Stage: test
    Stage: deploy
    Pipeline: LinkAhead

    #24872

      Pipeline passed for bc7f40b4 on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Daniel Hornung
    • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

      marked the checklist item Annotations in code (Gitlab comments) as completed

    • Daniel Hornung requested review from @henrik

      requested review from @henrik

    • Henrik tom Wörden resolved all threads

      resolved all threads

    • Henrik tom Wörden merged

      merged

    • Henrik tom Wörden mentioned in commit bc7f40b4

      mentioned in commit bc7f40b4

      • Please register or sign in to reply