Skip to content

F query quotation

Timm Fitschen requested to merge f-query-quotation into dev

Summary

Fixes the handling of queries like SELECT "name in quotes" .... The selected portions may include special characters as well (like the dot or the comma). Also, \ as an escape character is included.

https://gitlab.com/caosdb/caosdb-server/-/issues/130

Focus

Most of the actual work is done in the two new lexer modes, one for single quoted and one for double quoted expressions. This is the cleanest way, because it reduces the problem to looking for the next quotation of the same kind.

Test Environment

No manual testing needed. Unit tests and the integration tests in caosdb-pyinttest!39 (merged) should be enough.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports