Skip to content

Fix #217 and #221

Timm Fitschen requested to merge f-datatype-override into dev

Summary

Fix for #217 (closed) and #221 (closed)

Focus

  • The fix for #221 (closed) is only one missing catch clause.
  • Everything else is concerned with #217 (closed). The reverted code basically marked an entity for a necessary update where this was not necessary. This triggered some checks later which would then copy the override status of descriptions, names, and data types. This is done explicitly here instead.

Test Environment

Integration tests in caosdb-pyinttest!29 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading