Skip to content

F grpc datetime

Timm Fitschen requested to merge f-grpc-datetime into f-grpc-f-acm

Summary

Fix for date time values as per https://gitlab.indiscale.com/caosdb/customers/cfaed/management/-/issues/40

Focus

The problem was indeed a wrongfully used toString. Because the way datetimes are represented in the public API and in the database back-end, the toString method is not the correct one.

Test Environment

Test with your wiki setup, possibly.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading