Missing implementations for Value.equals(Value) for many cases made the server detect an update of properties (and hence users required certain permissions) where no update was actually happening.
Focus
Point the reviewer to the core of the code change. Where should they startreading? What should they focus on (e.g. security, performance,maintainability, user-friendliness, compliance with the specs, finding morecorner cases, concrete questions)?
Test Environment
How to set up a test environment for manual testing?
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a
focus and create gitlab comments for the reviewer. They should guide the
reviewer through the changes, explain your changes and also point out open
questions. For further good practices have a look at our review
guidelines
All automated tests pass
Reference related Issues
Up-to-date CHANGELOG.md
Annotations in code (Gitlab comments)
Intent of new code
Problems with old code
Why this implementation?
Check List for the Reviewer
I understand the intent of this MR
All automated tests pass
Up-to-date CHANGELOG.md
The test environment setup works and the intended behavior is
reproducible in the test environment
In-code documentation and comments are up-to-date.
Check: Are there specifications? Are they satisfied?
Florian Spreckelsen authored