Skip to content

EHN: simplify CheckPropValid and add usefull info when permission denied

Timm Fitschen requested to merge f-useful-error-message-permission-denied into dev

Summary

During debugging, I noticed that CheckPropValid does not return useful info when permission denied.

This MR simplifies the CheckPropValid.java/Job.java and add info which permission is missing.

Test Environment

Manual testing not necessary.

Automatic tests should be sufficient

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Merge request reports