Skip to content
Snippets Groups Projects

Merge f-GRPC-main to dev

Merged Timm Fitschen requested to merge f-grpc-main into dev

Summary

GRPC API (caosdb-proto 0.1)

Focus

  • Most of the code is new (duh)
  • Actual changes mostly are due to these things:
    1. The GRPC API has a 64bit range for INTEGER values and we had to handle that
    2. The GRPC API does not require ids for updates where these can be guessed
    3. The GRPC API defines a set of messages via the MessageCode enum. The old API was messy in this regard and we had to implement work-arounds for a lot of the members of the ServerMessages class because we had the goal that the old pyinttest suite would pass without changes. I noticed that some of the messages are not even used anymore, so I deleted them.

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues caosdb/customers/lfpb/management#451
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen changed the description

    changed the description

  • mentioned in issue #190 (moved)

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung changed the description

    changed the description

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Daniel Hornung added 4 commits

    added 4 commits

    • 23169ea0 - STY: Typos and renamed a few variables.
    • 1d052f29 - MAINT: Reworded messages and fixed typos.
    • bbf33a41 - ENH: fail for multiple requests (fail fast for unsupported requests)
    • ef187df5 - MAINT: Fixed typo in function name.

    Compare with previous version

  • Daniel Hornung
  • Daniel Hornung
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading