Skip to content

FIX #183

Timm Fitschen requested to merge f-date-time into dev

Summary

Fix for #183 (closed)

Focus

The problem was that the bad DateTime value could be parsed as a SemiCompleteDateTime, but there is no representation of such values which can be stored to the back-end (the back-end stores seconds since 1970 as integers, plus nanoseconds, if applicable). The new implementation tests if the toDatabaseString() method works and returns the appropriate error if not.

Test Environment

Integration tests in caosdb-pyinttest!20 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports