Skip to content
Snippets Groups Projects

F grpc f mixed write transactions

Merged Timm Fitschen requested to merge f-grpc-f-mixed-write-transactions into f-grpc-dev

Summary

Mixed-write transactions: caosdb/customers/lfpb/management#425

Focus

  • Most changes are in src/main/java/org/caosdb/server/grpc/EntityTransactionServiceImpl.java and generalize the old behavior (single write transactions to multiple and mixed transactions). It was a goal to preserve the order of the entities in the request and response which is a little annoying when string id's are involved which cannot be parsed to integer. This case is handled separately in failedWriteDueToStringId.
  • It was necessary to refactor WriteTransaction.deriveUpdate for update transactions where entities are being used which are inserted in the same transaction. See my comment there: !35 (comment 24884)

Test Environment

caosdb-cppinttest!17 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • [ ] Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • ab08dc9b - BUG: correctly handle string ids

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen added 2 commits

    added 2 commits

    • 3acacfc0 - 1 commit from branch f-grpc-dev
    • 27560346 - Merge branch 'f-grpc-dev' into f-grpc-f-mixed-write-transactions

    Compare with previous version

  • Timm Fitschen marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen requested review from @daniel

    requested review from @daniel

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading