Skip to content

F nan in lists

Timm Fitschen requested to merge f-nan-in-lists into dev

Summary

Fix for https://gitlab.com/caosdb/caosdb-server/-/issues/127

Focus

The problem was actually only a question of the case of the "NaN" keyword in combination with lists of doubles. When inserting a list with "NaN" as a double value the old implementation of DoubleDatatype.parseValue(Object value) was working as expected. The new implementation just assures that also "nan" (lower case!) is accepted.

Test Environment

No manual testing needed. Integration tests are in caosdb-pyinttest!14 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports