Summary
- Fix for #131 (closed)
- Fix for #134 (closed)
Focus
- Problem with #134 (closed) was a too restrictive lexer rule (
FROM
rule). SeeCQLLexer.g4
. - Problem with #131 (closed) was a too restrictive parser rule (
unit
rule). See CQLParser.g4`.
Test Environment
Tests in caosdb-pyinttest!7 (merged)
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Activity
mentioned in merge request caosdb-pyinttest!7 (merged)
- Resolved by Florian Spreckelsen
- Resolved by Florian Spreckelsen
requested review from @florian
added 8 commits
-
32c737f9...da90c18e - 7 commits from branch
dev
- ff5f91a7 - Merge branch 'dev' into f-double-white-space
-
32c737f9...da90c18e - 7 commits from branch
Please register or sign in to reply