query transaction filter (BEFORE/AFTER)
Summary
Fix/Enhancement of #132 (closed)
The issue was misclassified as bug, the documentation was no very helpful, apparently. Since the implementation was very straight forward, I decided to do it anyways.
Focus
The mysql backend api has not changed. Only the CQL parser (CQLParser.g4/CQLLexer.g4) and the filter implementation of the server (TransactionFilter.java) had to be extended.
Test Environment
Tests in caosdb-pyinttest!6 (merged) should be sufficient
Check List for the Author
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Activity
mentioned in merge request caosdb-pyinttest!6 (merged)
6686 6687 assertEquals("POV(pname,=,with)", sfq.filter.toString()); 6687 6688 assertNull(((POV) sfq.filter).getSubProperty()); 6688 6689 } 6690 6691 @Test 6692 /** String queryIssue132 = "FIND ENTITY WHICH HAS BEEN INSERTED AFTER TODAY"; */ 6693 public void testIssue132() { changed this line in version 3 of the diff
added 5 commits
-
406ab1e9...a35254cc - 4 commits from branch
dev
- e4b7fcc5 - Merge branch 'dev' into f-query-transaction-filter
-
406ab1e9...a35254cc - 4 commits from branch
requested review from @daniel
added 6 commits
-
6f7924cc...eefbef6d - 5 commits from branch
dev
- 183d1bbd - Merge branch 'dev' into f-query-transaction-filter
-
6f7924cc...eefbef6d - 5 commits from branch
Please register or sign in to reply