Skip to content
Snippets Groups Projects

F server 323

Merged Timm Fitschen requested to merge f-server-323 into dev
All threads resolved!

Summary

Corresponding changes for caosdb-mysqlbackend!20 (merged)

Related issue: #323 (closed)

Focus

The relevant change here is in the Query class, where we replace the casting to integer with the matchIdPattern function.

Test Environment

Inttests in caosdb-pyinttest!68 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Pipeline #42466 passed

Pipeline: LinkAhead

#42468

    Pipeline passed for e744ad71 on f-server-323

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 1 year ago (Oct 19, 2023 8:20am UTC)

    Merge details

    • Changes merged into dev with c0e43851.
    • Deleted the source branch.

    Pipeline #42640 passed

    Pipeline: LinkAhead

    #42642

      Pipeline passed for c0e43851 on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Timm Fitschen
    • Timm Fitschen
    • Timm Fitschen changed the description

      changed the description

    • Timm Fitschen marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Timm Fitschen marked the checklist item Reference related issues as completed

      marked the checklist item Reference related issues as completed

    • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

      marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    • Timm Fitschen marked the checklist item Up-to-date JSON schema (or not necessary) as completed

      marked the checklist item Up-to-date JSON schema (or not necessary) as completed

    • Timm Fitschen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

      marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

      marked the checklist item Annotations in code (Gitlab comments) as completed

    • mentioned in commit c0e43851

    • Henrik tom Wörden resolved all threads

      resolved all threads

    • Please register or sign in to reply
      Loading