Skip to content
Snippets Groups Projects

FIX: parsing of decimal numbers

Merged Henrik tom Wörden requested to merge f-fix-239 into dev
All threads resolved!

Summary

Fix for https://gitlab.com/linkahead/linkahead-server/-/issues/239

Focus

The decimal_number token could eat whitespaces which lead to the use of atom rule where it should not happen.

Test Environment

pipeline and new unit test

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Pipeline #42251 passed

Pipeline: LinkAhead

#42253

    Pipeline passed for 00cac469 on f-fix-239

    Approval is optional

    Merged by Timm FitschenTimm Fitschen 1 year ago (Oct 16, 2023 2:16pm UTC)

    Merge details

    • Changes merged into dev with 3e8bd5f7.
    • Deleted the source branch.

    Pipeline #42282 passed

    Pipeline: LinkAhead

    #42283

      Pipeline passed for 3e8bd5f7 on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden requested review from @timm

      requested review from @timm

    • mentioned in issue #322 (closed)

    • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

      marked the checklist item I understand the intent of this MR as completed

    • Timm Fitschen marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

      marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    • Timm Fitschen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

      marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

      marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    • Timm Fitschen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

      marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

      marked the checklist item In-code documentation and comments are up-to-date. as completed

    • Timm Fitschen resolved all threads

      resolved all threads

    • Timm Fitschen mentioned in commit 3e8bd5f7

      mentioned in commit 3e8bd5f7

    • merged

    • Please register or sign in to reply
      Loading