Skip to content
Snippets Groups Projects
Verified Commit b99d2822 authored by Timm Fitschen's avatar Timm Fitschen
Browse files

BUG: unnecessary check if user exists removed

parent 3a26c722
No related branches found
No related tags found
No related merge requests found
...@@ -24,7 +24,6 @@ ...@@ -24,7 +24,6 @@
*/ */
package caosdb.server.accessControl; package caosdb.server.accessControl;
import caosdb.server.caching.Cache;
import java.io.File; import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.util.HashSet; import java.util.HashSet;
...@@ -37,6 +36,7 @@ import org.apache.logging.log4j.Logger; ...@@ -37,6 +36,7 @@ import org.apache.logging.log4j.Logger;
import org.apache.shiro.authz.AuthorizationException; import org.apache.shiro.authz.AuthorizationException;
import org.jvnet.libpam.PAMException; import org.jvnet.libpam.PAMException;
import org.jvnet.libpam.UnixUser; import org.jvnet.libpam.UnixUser;
import caosdb.server.caching.Cache;
/** /**
* PAM UserSource for authenticating users via the Host's pam module. * PAM UserSource for authenticating users via the Host's pam module.
...@@ -260,7 +260,7 @@ public class Pam implements UserSource { ...@@ -260,7 +260,7 @@ public class Pam implements UserSource {
/** @see {@link UserSource#isValid(String, String)}. */ /** @see {@link UserSource#isValid(String, String)}. */
@Override @Override
public boolean isValid(final String username, final String password) { public boolean isValid(final String username, final String password) {
if (isUserExisting(username)) { if (username != null && isIncorporated(username)) {
return isValid(getPamScriptCaller(), username, password); return isValid(getPamScriptCaller(), username, password);
} }
return false; return false;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment