Skip to content
Snippets Groups Projects

Get parents recursively

Merged Daniel Hornung requested to merge f-get-parents-recursively into dev
All threads resolved!

Summary

Entity.get_parents_recursively() did not work for unretrieved parents. Does work now. See #159 (closed).

Focus

  • Does this solve the issue?
  • Is the wrapped-entity mangling the correct way? (If not, how could tests against this look like?)

Test Environment

See pyinttests: pytest-3 -k recurs or pytest-3 tests/test_recursive_parents.py

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • mentioned in issue #159 (closed)

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung requested review from @henrik

    requested review from @henrik

  • Henrik tom Wörden
  • added 5 commits

    • 30595fec - MAINT: use list instead of _Parents
    • 89b28858 - MAINT: rename _Parents to _ParentList
    • 604b9fc7 - DOC: document _wrap a bit
    • fb7019ce - MAINT: use another var to make code clearer
    • e7a143cc - DOC: add code style comments

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Daniel Hornung
  • Henrik tom Wörden resolved all threads

    resolved all threads

  • Daniel Hornung mentioned in commit 78f54773

    mentioned in commit 78f54773

  • Please register or sign in to reply
    Loading