F bool config options

Summary

For #148 (closed). The value of config["ssl_insecure"] is interpreted as Boolean, but was expected to be str when raising the No-SSL-Verification warning.

Focus

Extended unit test and correctly ask in if clause.

Test Environment

Unttest; also check py adding ssl_insecure = True and ssl_insecure=False to your pycaosdb.ini and verify that the warning is thrown correctly.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosdb/connection/connection.py

@@ -282,7 +282,7 @@ class _DefaultCaosDBServerConnection(CaosDBServerConnection):
         verify = True
         if "cacert" in config:
             verify = config["cacert"]
-        if "ssl_insecure" in config and config["ssl_insecure"].lower() == "true":
+        if "ssl_insecure" in config and config["ssl_insecure"]:
             _LOGGER.warning("*** Warning! ***\n"
                             "Insecure SSL mode, certificate will not be checked! "
                             "Please consider removing the `ssl_insecure` configuration option.\n"