Adds support for http proxies (as per https://gitlab.indiscale.com/caosdb/customers/aba/management/-/issues/32).
https_proxy
and http_proxy
parameters and config options and by respecting the widely used HTTPS_PROXY
and HTTP_PROXY
environment variables. This deprecates the socket_proxy
option because the functionality is contained in the new options.requests
library. This is a long overdue refactoring because the old custom implementation for streaming https connections was from the early days of caosdb-pylib when streaming + https was not supported by any standard library back then. This reduces the complexity and uses a well-tested, regularly updated, yet stable library instead.python-dateutil
because it is used in high_level_api.py
.Manual testing required!
ssh -D 8888 localhost
(mind: if you exit this, the socks proxy is gone...)pycaosdb.ini
for socks proxy or use the env varAlso try to configure a wrong socks proxy (e.g. wrong port) - this should fail.
docker run --rm --name tinyproxy -p 8888:8888 -e "ALLOWED=255.255.255.255/0" ajoergensen/tinyproxy
pycaosdb.ini
for http proxy or use the env varAlso try to configure a wrong http proxy.
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.