Skip to content
Snippets Groups Projects

Use "trigger" keyword for pipeline

Merged Use "trigger" keyword for pipeline
f-trigger into dev
All threads resolved!
Merged Daniel Hornung requested to merge f-trigger into dev
All threads resolved!

Summary

Use "trigger" keyword for pipeline. See #127 (closed).

Focus

Are the variables set correctly?

Test Environment

Look at pipelines and see if they work.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary) Not necessary.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Pipeline #24431 failed

Stage: code_style
Stage: linting
Stage: test
Stage: deploy
Pipeline: LinkAhead

#24433

    Pipeline failed for 1e507628 on f-trigger

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 2 years ago (Jun 21, 2022 4:57pm UTC)

    Merge details

    • Changes merged into dev with c36376e0.
    • Deleted the source branch.

    Pipeline #25259 passed

    Stage: code_style
    Stage: linting
    Stage: setup
    Stage: test
    Stage: deploy
    Pipeline: LinkAhead

    #25260

      Pipeline passed for c36376e0 on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Daniel Hornung added 1 commit

      added 1 commit

      • 1085c063 - FIX: Don't inherit variables (especially not the CI_REGISTRY_IMAGE).

      Compare with previous version

    • Daniel Hornung added 1 commit

      added 1 commit

      • 5ae45a8f - FIX: Don't inherit all variables (especially not CI_REGISTRY_IMAGE).

      Compare with previous version

    • Daniel Hornung marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Daniel Hornung
    • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

      marked the checklist item Annotations in code (Gitlab comments) as completed

    • Daniel Hornung requested review from @henrik

      requested review from @henrik

    • Daniel Hornung added 2 commits

      added 2 commits

      • 2010c19a - 1 commit from branch dev
      • 1e507628 - Merge branch 'dev' into f-trigger

      Compare with previous version

    • Henrik tom Wörden resolved all threads

      resolved all threads

    • Henrik tom Wörden mentioned in commit c36376e0

      mentioned in commit c36376e0

    • Henrik tom Wörden merged

      merged

      • Please register or sign in to reply