Skip to content

ENH: to_graphics now has `no_shadow` option.

Daniel Hornung requested to merge f-plantuml-without-shadow into dev

Summary

Just a small new option for plantuml generation

Focus

  • Does this option do what it should?
  • Are there any negative side-effects?

Test Environment

import caosdb as db; from caosdb.utils import plantuml
cont = db.Container().append(db.RecordType(name="test"))
plantuml.to_graphics(cont, "test_with")
plantuml.to_graphics(cont, "test_without", no_shadow=True)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues There are no issues.
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Loading