ENH: to_graphics now has `no_shadow` option.

Summary

Just a small new option for plantuml generation

Focus

• Does this option do what it should?
• Are there any negative side-effects?

Test Environment

import caosdb as db; from caosdb.utils import plantuml
cont = db.Container().append(db.RecordType(name="test"))
plantuml.to_graphics(cont, "test_with")
plantuml.to_graphics(cont, "test_without", no_shadow=True)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues There are no issues.
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

assigned to @salexan

marked the checklist item All automated tests pass as completed

marked the checklist item Annotations in code (Gitlab comments) as completed

resolved all threads

The code looks fine.

However, on my machine with plantuml version:

PlantUML version 1.2022.4 (Sat Apr 09 15:29:17 CEST 2022)

No shadows are generated anymore with the default style.

Could you update and check whether that's still relevant?

Also the documentation does not show shadows anymore: https://plantuml.com/de/class-diagram

I believe it will still be relevant for users with older versions. The themes in https://github.com/plantuml/plantuml/tree/master/themes have been changed 5-7 months ago, and the themes were included 1 year ago. I would vote for merging, because it does not hurt.

The new themes are great, btw.

Oh, and there still are many themes with shadows: https://the-lum.github.io/puml-themes-gallery/

marked the checklist item I understand the intent of this MR as completed

marked the checklist item All automated tests pass as completed

marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

marked the checklist item In-code documentation and comments are up-to-date. as completed

mentioned in commit a9220368

merged