Skip to content

FIX: new systems expect encoded body

Henrik tom Wörden requested to merge f-encode into dev

Summary

So far the MockupResponse always returned a str. On new systems however it is expected that the return value is bytes. When debug=1 is enabled for the Container on a new OS, the MockupResponse return value thus results in an error.

Focus

See for example _log_response in model.py.

I also changed unittests accordingly.

Note

What is the python version corresponding to 0x03000000? Can we drop this condition entirely?

Test Environment

Run advancedtools unittests with debug=1.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports