F parse acl

Summary

Fixes the parsing of EntityACLs #106

Focus

The parsing uses the grant and deny methods of the ACL class. For convenience reasons, these would remove any present contradicting rules. This makes a lot of sense when an ACL is being constructed from scratch, but for parsing the server's response it is necessary to keep contradicting rules.

Test Environment

No manual testing required. Just check the new unit test.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosdb/common/models.py

@@ -305,6 +305,7 @@ class Entity(object):
             Whether a contradicting denial (with same priority flag) in this
             ACL will be revoked.
         """
+        # @review Florian Spreckelsen 2022-03-17
         self.acl.grant(realm=realm, username=username, role=role,
                        permission=permission, priority=priority,
                        revoke_denial=revoke_denial)
@@ -339,6 +340,7 @@ class Entity(object):
             Whether a contradicting grant (with same priority flag) in this
             ACL will be revoked.
         """
+        # @review Florian Spreckelsen 2022-03-17
         self.acl.deny(realm=realm, username=username, role=role,
                       permission=permission, priority=priority,
                       revoke_grant=revoke_grant)
@@ -3762,6 +3764,7 @@ class ACL():
             The xml element containing the ACL rules, i.e. <Grant> and <Deny>
             rules.
         """
+        # @review Florian Spreckelsen 2022-03-17
         for e in xml:
             role = e.get("role")
             username = e.get("username")
@@ -3887,6 +3890,7 @@ class ACL():
             Whether a contradicting denial (with same priority flag) in this
             ACL will be revoked.
         """
+        # @review Florian Spreckelsen 2022-03-17
         priority = self._get_boolean_priority(priority)
         item = ACI(role=role, username=username,
                    realm=realm, permission=permission)
@@ -3928,6 +3932,7 @@ class ACL():
             Whether a contradicting grant (with same priority flag) in this
             ACL will be revoked.
         """
+        # @review Florian Spreckelsen 2022-03-17
         priority = self._get_boolean_priority(priority)
         item = ACI(role=role, username=username,
                    realm=realm, permission=permission)