Skip to content
Snippets Groups Projects

F copy entity

Merged F copy entity
f-copy-entity into dev
1 unresolved thread
Merged Alexander Schlemmer requested to merge f-copy-entity into dev
1 unresolved thread

Summary

Function to copy an entity.

Note to reviewer: This MR depends on f-merge-entities.

Test Environment

There is a unit test.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Add type hints in created/changed code
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Pipeline #21662 passed with warnings

Stage: code_style
Stage: linting
Stage: test
Stage: deploy
Pipeline: LinkAhead

#21663

    Pipeline passed with warnings for 8f6d3528 on f-copy-entity

    Approval is optional

    Merged by Alexander SchlemmerAlexander Schlemmer 2 years ago (Apr 12, 2022 1:40pm UTC)

    Merge details

    • Changes merged into with 77c1d75e.
    • Deleted the source branch.

    Pipeline #21896 passed with warnings

    Stage: code_style
    Stage: linting
    Stage: setup
    Stage: test
    Stage: deploy
    Pipeline: LinkAhead

    #21897

      Pipeline passed with warnings for 77c1d75e on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Alexander Schlemmer marked the checklist item Annotations in code (Gitlab comments) as completed

      marked the checklist item Annotations in code (Gitlab comments) as completed

    • Alexander Schlemmer mentioned in merge request !50 (closed)

      mentioned in merge request !50 (closed)

    • Florian Spreckelsen requested review from @timm

      requested review from @timm

    • Henrik tom Wörden added 8 commits

      added 8 commits

      • f66eba25 - STY: style fixes for this branch
      • a02f3bf7 - TST: added test stub
      • 5075530a - TST: added a basic unit test for merge entities function
      • aea1beaa - FIX: Workaround for bug 109 (problems with xml representations of list values)
      • a0c1db9f - FIX: added workaround for bug 109 and corresponding tests
      • ded2b128 - FIX: added unit for workaround
      • a73c710e - MAINT: move doc file to f-refactor-high-level-api
      • 394d2f5d - Merge branch 'f-merge-entities' into f-copy-entity

      Compare with previous version

      Toggle commit list
    • Henrik tom Wörden
      Henrik tom Wörden @henrik started a thread on an old version of the diff
      • src/caosdb/apiutils.py
      691 if entity.role == "File":
      692 new = File()
      693 elif entity.role == "Property":
      694 new = Property()
      695 elif entity.role == "RecordType":
      696 new = RecordType()
      697 elif entity.role == "Record":
      698 new = Record()
      699 elif entity.role == "Entity":
      700 new = Entity()
      701 else:
      702 raise RuntimeError("Unkonwn role.")
      703
      704 # Copy special attributes:
      705 # TODO: this might rise an exception when copying
      706 # special file attributes like checksum and size.
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden
    • Henrik tom Wörden requested review from @henrik and removed review request for @timm

      requested review from @henrik and removed review request for @timm

    • Alexander Schlemmer added 1 commit

      added 1 commit

      • 465f41f2 - DOC: renamed COMAPRED to SPECIAL_ATTRIBUTES and added documentation

      Compare with previous version

    • Alexander Schlemmer added 1 commit

      added 1 commit

      • 7db9b86d - MAINT: removed debugging message

      Compare with previous version

    • Alexander Schlemmer added 2 commits

      added 2 commits

      • e60c02bb - MAINT: moved copy_entity to member function in models
      • b092807e - MAINT: renamed copy_entity to copy

      Compare with previous version

    • Alexander Schlemmer added 1 commit

      added 1 commit

      • f3622f43 - DOC: updated docstring of merge_entities

      Compare with previous version

    • Alexander Schlemmer added 1 commit

      added 1 commit

      • a68883c4 - TST: adapted test to use member function instead of copy_entity

      Compare with previous version

    • Alexander Schlemmer added 1 commit

      added 1 commit

      • 8f6d3528 - DOC: updated merge_entities docstr to note that the function is currently experimental

      Compare with previous version

    • Alexander Schlemmer enabled an automatic merge when the pipeline for 8f6d3528 succeeds

      enabled an automatic merge when the pipeline for 8f6d3528 succeeds

    • Alexander Schlemmer mentioned in commit 77c1d75e

      mentioned in commit 77c1d75e

    • Alexander Schlemmer merged

      merged

      • Please register or sign in to reply