F fix comparison
All threads resolved!
All threads resolved!
Summary
This is a fix for #94 (closed). These comparisons might be needed in the new crawler framework. Please review whether the suggested amendment could potentially break other things.
Test Environment
There are unit tests supplied with this merge request.
Check List for the Author
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Add type hints in created/changed code -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Activity
requested review from @florian
assigned to @salexan
- Resolved by Florian Spreckelsen
added 21 commits
-
60aac5df...ffe910e7 - 19 commits from branch
dev
- 73e39a29 - Merge branch 'dev' into f-fix-comparison
- 6a87eceb - TST: Add python 3.10 to tox.ini
-
60aac5df...ffe910e7 - 19 commits from branch
mentioned in commit 7b18356d
Please register or sign in to reply