Skip to content
Snippets Groups Projects

FIX: compare function did not check units

Merged Alexander Schlemmer requested to merge f-compare-unit into dev
1 unresolved thread

Summary

Fix for #90 (closed)

Focus

A few lines added analogous to existing code. Please check whether this is appropriate.

Test Environment

Just run pytest.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Add type hints in created/changed code
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
637 637 newdiff["properties"][prop.name]["datatype"] = \
638 638 matching[0].datatype
639 639
640 if (prop.unit != matching[0].unit):
  • Alexander Schlemmer marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Alexander Schlemmer marked this merge request as ready

    marked this merge request as ready

  • mentioned in commit 2fff66ff

  • Please register or sign in to reply
    Loading