Skip to content

FIX: compare function did not check units

Alexander Schlemmer requested to merge f-compare-unit into dev

Summary

Fix for #90 (closed)

Focus

A few lines added analogous to existing code. Please check whether this is appropriate.

Test Environment

Just run pytest.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Add type hints in created/changed code
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports